Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit an update to Gemfile.lock when bumping the version. #151

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

myronmarston
Copy link
Collaborator

In ElasticGraph v0.19.0.0 and before, we did not keep the Gemfile.lock under source control, and our release process didn't need to update it and commit it as part of bumping the version. Now that we keep it under source control, we need to update it and commit it.

In ElasticGraph v0.19.0.0 and before, we did not keep the `Gemfile.lock`
under source control, and our release process didn't need to update it
and commit it as part of bumping the version. Now that we keep it under
source control, we need to update it and commit it.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@myronmarston myronmarston marked this pull request as ready for review February 7, 2025 07:51
Copy link
Collaborator

@BrianSigafoos-SQ BrianSigafoos-SQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myronmarston myronmarston merged commit f98e4a5 into main Feb 7, 2025
19 of 20 checks passed
@myronmarston myronmarston deleted the myron/commit-gemfile-lock-when-releasing branch February 7, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants